Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 647753004: Don't set sent_top_controls_delta when root layer doesn't exist. (Closed)

Created:
6 years, 2 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 2 months ago
Reviewers:
bokan
CC:
cc-bugs_chromium.org, chromium-reviews, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't set sent_top_controls_delta when root layer doesn't exist. Soon after CC initialization when the layer tree doesn't exist yet, the top controls delta can still be set. In that case, an early return in LTH::ApplyScrollAndScale doesn't forward the value to Blink -- the "sent_" value is misleading here, and this causes the delta to get clobbered on the next commit. Avoid this scenario by matching the LTH-side early-return in LTHI. NOTRY=true BUG=423139 Committed: https://crrev.com/5d3e3b4f0fbd7a9ec4a6f41d8680e548f253797c Cr-Commit-Position: refs/heads/master@{#299426}

Patch Set 1 #

Patch Set 2 : Remove unused variable in unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 9 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
aelias_OOO_until_Jul13
Hi bokan@, PTAL.
6 years, 2 months ago (2014-10-13 23:14:04 UTC) #2
bokan
lgtm
6 years, 2 months ago (2014-10-14 02:01:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647753004/1
6 years, 2 months ago (2014-10-14 02:04:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/24155)
6 years, 2 months ago (2014-10-14 02:19:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647753004/60001
6 years, 2 months ago (2014-10-14 03:45:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-14 03:51:08 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 03:52:17 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d3e3b4f0fbd7a9ec4a6f41d8680e548f253797c
Cr-Commit-Position: refs/heads/master@{#299426}

Powered by Google App Engine
This is Rietveld 408576698