Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 647753003: Make ARRAYSIZE_UNSAFE() just use arraysize(). (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, Tom Sepez
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ARRAYSIZE_UNSAFE() just use arraysize(). For every two problems that C++11 causes, it fixes at least one. R=thestig@chromium.org,tsepez@chromium.org BUG=423134 Committed: https://crrev.com/eb552d78ea8a447dcecc5d828bc11eae7a2121d3 Cr-Commit-Position: refs/heads/master@{#299419}

Patch Set 1 #

Patch Set 2 : C++ #

Patch Set 3 : more C++ #

Patch Set 4 : added bug #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -56 lines) Patch
M base/macros.h View 1 2 3 3 chunks +5 lines, -47 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/utility/chrome_content_utility_ipc_whitelist.cc View 1 2 1 chunk +7 lines, -4 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
viettrungluu
tsepez -> chrome/utility/chrome_content_utility_ipc_whitelist.cc thestig -> everything else
6 years, 2 months ago (2014-10-13 22:38:39 UTC) #2
Tom Sepez
lgtm
6 years, 2 months ago (2014-10-13 22:58:14 UTC) #3
Tom Sepez
https://codereview.chromium.org/647753003/diff/320001/chrome/utility/chrome_content_utility_ipc_whitelist.cc File chrome/utility/chrome_content_utility_ipc_whitelist.cc (right): https://codereview.chromium.org/647753003/diff/320001/chrome/utility/chrome_content_utility_ipc_whitelist.cc#newcode24 chrome/utility/chrome_content_utility_ipc_whitelist.cc:24: const size_t kMessageWhitelistSize = 0; Alternatively, It looks like ...
6 years, 2 months ago (2014-10-13 23:07:13 UTC) #4
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-13 23:17:18 UTC) #5
viettrungluu
Thanks, all. On 2014/10/13 23:07:13, Tom Sepez wrote: > https://codereview.chromium.org/647753003/diff/320001/chrome/utility/chrome_content_utility_ipc_whitelist.cc > File chrome/utility/chrome_content_utility_ipc_whitelist.cc (right): > ...
6 years, 2 months ago (2014-10-13 23:35:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647753003/320001
6 years, 2 months ago (2014-10-13 23:37:09 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:320001)
6 years, 2 months ago (2014-10-14 01:40:09 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:40:54 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eb552d78ea8a447dcecc5d828bc11eae7a2121d3
Cr-Commit-Position: refs/heads/master@{#299419}

Powered by Google App Engine
This is Rietveld 408576698