Remove -webkit-aspect-ratio.

Remove -webkit-aspect-ratio.

This property is parsed and stored on RenderStyle, but it's not
used anywhere, i.e. it has no effect.

If we later decide that we want this after all, we can re-implement
it as 'aspect-ratio' behind a flag.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183652

[andersr, 2014-10-10 12:14:32]

andersr@opera.com changed reviewers:
+ tabatkins@chromium.org, timloh@chromium.org

[andersr, 2014-10-10 12:14:33]

Judging from https://bugs.webkit.org/show_bug.cgi?id=47738 , it looks like
aspect-ratio was never actually implemented (only parsed and stored).

Tab, is aspect-ratio still a thing? Should we just remove -webkit-aspect-ratio?

[Timothy Loh, 2014-10-10 14:24:41]

On 2014/10/10 12:14:33, andersr wrote:
> Judging from https://bugs.webkit.org/show_bug.cgi?id=47738 , it looks like
> aspect-ratio was never actually implemented (only parsed and stored).
> 
> Tab, is aspect-ratio still a thing? Should we just remove
-webkit-aspect-ratio?

Let's just remove it. It basically does nothing (aside from one check in
RenderFlexibleBox) and it's basically never used,
https://www.chromestatus.com/metrics/css/timeline/popularity/176

I guess this is trivial enough to not need an intent to remove email :)

[andersr, 2014-10-12 13:27:12]

> Let's just remove it.

Yes. Done. PTAL.

> I guess this is trivial enough to not need an intent to remove email :)

Yeah, it's not really implemented, so nobody could possibly depend on that
property. (Except obscure computed-style abuse).

[Timothy Loh, 2014-10-12 23:50:05]

On 2014/10/12 13:27:12, andersr wrote:
> > Let's just remove it.
> 
> Yes. Done. PTAL.
> 
> > I guess this is trivial enough to not need an intent to remove email :)
> 
> Yeah, it's not really implemented, so nobody could possibly depend on that
> property. (Except obscure computed-style abuse).

lgtm, but update the title too.

[andersr, 2014-10-13 08:43:49]

On 2014/10/12 23:50:05, Timothy Loh wrote:
> On 2014/10/12 13:27:12, andersr wrote:
> > > Let's just remove it.
> > 
> > Yes. Done. PTAL.
> > 
> > > I guess this is trivial enough to not need an intent to remove email :)
> > 
> > Yeah, it's not really implemented, so nobody could possibly depend on that
> > property. (Except obscure computed-style abuse).
> 
> lgtm, but update the title too.

Done.

[andersr, 2014-10-13 08:43:54]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 08:44:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647723002/440001

[commit-bot: I haz the power, 2014-10-13 09:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 09:49:35]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[andersr, 2014-10-13 10:27:33]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 10:28:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647723002/660001

[commit-bot: I haz the power, 2014-10-13 11:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 11:36:17]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[andersr, 2014-10-13 11:47:47]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 11:48:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647723002/860001

[commit-bot: I haz the power, 2014-10-13 13:42:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 13:42:30]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31487)

[andersr, 2014-10-13 13:46:39]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 13:47:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647723002/860001

[commit-bot: I haz the power, 2014-10-13 15:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 15:52:40]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31511)

[andersr, 2014-10-14 06:40:02]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-14 06:40:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647723002/860001

[commit-bot: I haz the power, 2014-10-14 08:04:01]

Committed patchset #5 (id:860001) as 183652