Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 647713004: Fix 'Automatic name servers' display in Settings' (Closed)

Created:
6 years, 2 months ago by stevenjb
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix 'Automatic name servers' display in Settings' If 'Automatic' is not the current name server selection we should show the saved values instead of the current values. BUG=417387 Committed: https://crrev.com/7166a829d8756995ff202a7fa0b958e7b39fad29 Cr-Commit-Position: refs/heads/master@{#300715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
6 years, 2 months ago (2014-10-22 17:05:40 UTC) #2
tbarzic
lgtm
6 years, 2 months ago (2014-10-22 17:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647713004/1
6 years, 2 months ago (2014-10-22 17:23:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 18:33:59 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:35:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7166a829d8756995ff202a7fa0b958e7b39fad29
Cr-Commit-Position: refs/heads/master@{#300715}

Powered by Google App Engine
This is Rietveld 408576698