Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: test/mjsunit/es6/typed-array-iterator.js

Issue 647703003: Don't expose Array.prototype.values as it breaks webcompat (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/es6/array-iterator.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 var constructors = [Uint8Array, Int8Array, 6 var constructors = [Uint8Array, Int8Array,
7 Uint16Array, Int16Array, 7 Uint16Array, Int16Array,
8 Uint32Array, Int32Array, 8 Uint32Array, Int32Array,
9 Float32Array, Float64Array, 9 Float32Array, Float64Array,
10 Uint8ClampedArray]; 10 Uint8ClampedArray];
11 11
12 function TestTypedArrayPrototype(constructor) { 12 function TestTypedArrayPrototype(constructor) {
13 assertTrue(constructor.prototype.hasOwnProperty('entries')); 13 assertTrue(constructor.prototype.hasOwnProperty('entries'));
14 assertTrue(constructor.prototype.hasOwnProperty('values')); 14 assertTrue(constructor.prototype.hasOwnProperty('values'));
15 assertTrue(constructor.prototype.hasOwnProperty('keys')); 15 assertTrue(constructor.prototype.hasOwnProperty('keys'));
16 assertTrue(constructor.prototype.hasOwnProperty(Symbol.iterator)); 16 assertTrue(constructor.prototype.hasOwnProperty(Symbol.iterator));
17 17
18 assertFalse(constructor.prototype.propertyIsEnumerable('entries')); 18 assertFalse(constructor.prototype.propertyIsEnumerable('entries'));
19 assertFalse(constructor.prototype.propertyIsEnumerable('values')); 19 assertFalse(constructor.prototype.propertyIsEnumerable('values'));
20 assertFalse(constructor.prototype.propertyIsEnumerable('keys')); 20 assertFalse(constructor.prototype.propertyIsEnumerable('keys'));
21 assertFalse(constructor.prototype.propertyIsEnumerable(Symbol.iterator)); 21 assertFalse(constructor.prototype.propertyIsEnumerable(Symbol.iterator));
22 22
23 assertEquals(Array.prototype.entries, constructor.prototype.entries); 23 assertEquals(Array.prototype.entries, constructor.prototype.entries);
24 assertEquals(Array.prototype.values, constructor.prototype.values); 24 assertEquals(Array.prototype[Symbol.iterator], constructor.prototype.values);
25 assertEquals(Array.prototype.keys, constructor.prototype.keys); 25 assertEquals(Array.prototype.keys, constructor.prototype.keys);
26 assertEquals(Array.prototype.values, constructor.prototype[Symbol.iterator]); 26 assertEquals(Array.prototype[Symbol.iterator], constructor.prototype[Symbol.it erator]);
27 } 27 }
28 constructors.forEach(TestTypedArrayPrototype); 28 constructors.forEach(TestTypedArrayPrototype);
29 29
30 30
31 function TestTypedArrayValues(constructor) { 31 function TestTypedArrayValues(constructor) {
32 var array = [1, 2, 3]; 32 var array = [1, 2, 3];
33 var i = 0; 33 var i = 0;
34 for (var value of new constructor(array)) { 34 for (var value of new constructor(array)) {
35 assertEquals(array[i++], value); 35 assertEquals(array[i++], value);
36 } 36 }
37 assertEquals(i, array.length); 37 assertEquals(i, array.length);
38 } 38 }
39 constructors.forEach(TestTypedArrayValues); 39 constructors.forEach(TestTypedArrayValues);
OLDNEW
« no previous file with comments | « test/mjsunit/es6/array-iterator.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698