Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 647703003: Don't expose Array.prototype.values as it breaks webcompat (Closed)

Created:
4 years, 5 months ago by adamk
Modified:
4 years, 5 months ago
CC:
v8-dev, wingo
Project:
v8
Visibility:
Public.

Description

Don't expose Array.prototype.values as it breaks webcompat Some versions of Outlook Web Access test for the existence of a 'values' property on Array instances, so adding the 'values' iterator to the prototype (even with @@unscopeables) causes breakage. This matches Gecko: they ship Array.prototype.{keys,entries} but not 'values'. BUG=409858 LOG=Y R=arv@chromium.org, danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24706

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M src/array.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/array-iterator.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/arguments-iterator.js View 1 3 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/es6/array-iterator.js View 1 6 chunks +7 lines, -10 lines 0 comments Download
M test/mjsunit/es6/typed-array-iterator.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
adamk
4 years, 5 months ago (2014-10-17 19:35:47 UTC) #2
arv (Not doing code reviews)
LGTM
4 years, 5 months ago (2014-10-17 20:01:27 UTC) #3
danno
lgtm
4 years, 5 months ago (2014-10-17 20:09:05 UTC) #4
adamk
4 years, 5 months ago (2014-10-17 20:12:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24706 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698