Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 647653002: Move forwardInputEvent from RenderFrame to RenderFrameProxy. (Closed)

Created:
6 years, 2 months ago by Charlie Reis
Modified:
6 years, 2 months ago
Reviewers:
kenrb
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move forwardInputEvent from RenderFrame to RenderFrameProxy. Depends on https://codereview.chromium.org/642203002. BUG=346764 TEST=Input events work in OOPIFs with --site-per-process. Committed: https://crrev.com/5834fe5e39991e80c096e9068e8e095e44d7c214 Cr-Commit-Position: refs/heads/master@{#299196}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove forward declare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M content/renderer/render_frame_impl.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_proxy.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Charlie Reis
Ken, this is the Chrome half of https://codereview.chromium.org/642203002. Can you take a look?
6 years, 2 months ago (2014-10-10 03:42:51 UTC) #2
kenrb
lgtm https://codereview.chromium.org/647653002/diff/1/content/renderer/render_frame_impl.h File content/renderer/render_frame_impl.h (left): https://codereview.chromium.org/647653002/diff/1/content/renderer/render_frame_impl.h#oldcode453 content/renderer/render_frame_impl.h:453: virtual void forwardInputEvent(const blink::WebInputEvent* event); Can we remove ...
6 years, 2 months ago (2014-10-10 19:41:58 UTC) #3
Charlie Reis
Thanks! https://codereview.chromium.org/647653002/diff/1/content/renderer/render_frame_impl.h File content/renderer/render_frame_impl.h (left): https://codereview.chromium.org/647653002/diff/1/content/renderer/render_frame_impl.h#oldcode453 content/renderer/render_frame_impl.h:453: virtual void forwardInputEvent(const blink::WebInputEvent* event); On 2014/10/10 19:41:58, ...
6 years, 2 months ago (2014-10-10 19:49:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647653002/170001
6 years, 2 months ago (2014-10-10 21:32:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:170001)
6 years, 2 months ago (2014-10-10 21:51:03 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 21:51:39 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5834fe5e39991e80c096e9068e8e095e44d7c214
Cr-Commit-Position: refs/heads/master@{#299196}

Powered by Google App Engine
This is Rietveld 408576698