Issue 647643002: Skips Chrome icon in Athena home card.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647643002: Skips Chrome icon in Athena home card. (Closed)

Created:
6 years, 2 months ago by Jun Mukai

Modified:
6 years, 2 months ago

Reviewers:
oshima

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Skips Chrome icon in Athena home card. Invoking NTP is meaningless in Athena. See the bug for the details. BUG=421677 R=oshima@chromium.org Committed: https://crrev.com/ec683477d778661111feed85eb34a531f2bff480 Cr-Commit-Position: refs/heads/master@{#299344}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	athena/extensions/extension_app_model_builder.cc	View		2 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647643002/1

6 years, 2 months ago (2014-10-13 19:09:33 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-13 19:31:30 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ec683477d778661111feed85eb34a531f2bff480
Cr-Commit-Position: refs/heads/master@{#299344}