Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 647623002: Cleanup: Actually remove base/file_util.h. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
brettw, no sievers
CC:
chromium-reviews, piman+watch_chromium.org, erikwright+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Actually remove base/file_util.h. Committed: https://crrev.com/4cf9a176d31d40f35e7b56939832ea43f857180f Cr-Commit-Position: refs/heads/master@{#299155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
D base/file_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_format.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Lei Zhang
Once and for all!
6 years, 2 months ago (2014-10-10 01:48:09 UTC) #2
brettw
yay! LGTM
6 years, 2 months ago (2014-10-10 17:19:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647623002/1
6 years, 2 months ago (2014-10-10 18:02:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/16968)
6 years, 2 months ago (2014-10-10 18:09:48 UTC) #7
Lei Zhang
+sievers for gpu/
6 years, 2 months ago (2014-10-10 18:34:49 UTC) #9
no sievers
lgtm
6 years, 2 months ago (2014-10-10 18:39:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647623002/1
6 years, 2 months ago (2014-10-10 18:53:07 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 18:58:07 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 18:58:58 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4cf9a176d31d40f35e7b56939832ea43f857180f
Cr-Commit-Position: refs/heads/master@{#299155}

Powered by Google App Engine
This is Rietveld 408576698