Chromium Code Reviews
Help | Chromium Project | Sign in
(296)

Issue 6476014: Merge 73913 - When performing SSL client authentication on Windows via NSS, c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 73913 - When performing SSL client authentication on Windows via NSS, change the returned key type to use a PCERT_KEY_CONTEXT allocated via NSS's PORT_Alloc(), rather than an HCRYPTPROV, for native client certificate authentication.

There are two reasons for doing this; first, a PCERT_KEY_CONTEXT lets us transmit a dwKeySpec, indicating whether to use the AT_KEYEXCHANGE or AT_SIGNATURE key for CryptoAPI keys. Second, a small piece of syntactic fluff, a PCERT_KEY_CONTEXT easily supports CNG keys for Vista+, which though not presently supported, is a TODO.

TBR=rsleevi
BUG=37560, 71748
TEST=Perform SSL client auth on Windows.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -76 lines) Lint Patch
M net/socket/ssl_client_socket_nss.cc View 3 chunks +13 lines, -56 lines 0 comments 0 errors Download
M net/third_party/nss/ssl/ssl.h View 1 chunk +6 lines, -2 lines 0 comments 0 errors Download
M net/third_party/nss/ssl/sslimpl.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M net/third_party/nss/ssl/sslplatf.c View 8 chunks +21 lines, -17 lines 0 comments 3 errors Download
Trybot results:
Commit:

Messages

Total messages: 1

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6