Chromium Code Reviews
Help | Chromium Project | Sign in
(168)

Issue 6476014: Merge 73913 - When performing SSL client authentication on Windows via NSS, c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by wtc
Modified:
3 years, 10 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 73913 - When performing SSL client authentication on Windows via NSS, change the returned key type to use a PCERT_KEY_CONTEXT allocated via NSS's PORT_Alloc(), rather than an HCRYPTPROV, for native client certificate authentication. There are two reasons for doing this; first, a PCERT_KEY_CONTEXT lets us transmit a dwKeySpec, indicating whether to use the AT_KEYEXCHANGE or AT_SIGNATURE key for CryptoAPI keys. Second, a small piece of syntactic fluff, a PCERT_KEY_CONTEXT easily supports CNG keys for Vista+, which though not presently supported, is a TODO. TBR=rsleevi BUG=37560, 71748 TEST=Perform SSL client auth on Windows.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -76 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 3 chunks +13 lines, -56 lines 0 comments Download
M net/third_party/nss/ssl/ssl.h View 1 chunk +6 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/nss/ssl/sslplatf.c View 8 chunks +21 lines, -17 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 1 (0 generated)
wtc
4 years, 1 month ago (2011-02-09 23:17:11 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted