Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 647573004: -Add README for building go sample application (Closed)

Created:
6 years, 1 month ago by gauthamt
Modified:
6 years, 1 month ago
Reviewers:
jamesr, qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

-Add README for building go sample application -Add README for building go system bindings test -Build rule changes R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1a2084a2f46271a3b07f6e060d269314cbfd4405

Patch Set 1 #

Total comments: 2

Patch Set 2 : README modifications. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -15 lines) Patch
M build/go/rules.gni View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/go/sample_app/README.txt View 1 1 chunk +24 lines, -11 lines 0 comments Download
A mojo/go/tests/README.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/libevent/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/modp_b64/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
gauthamt
6 years, 1 month ago (2014-10-29 21:36:19 UTC) #2
qsr
https://codereview.chromium.org/647573004/diff/1/mojo/go/sample_app/README.txt File mojo/go/sample_app/README.txt (right): https://codereview.chromium.org/647573004/diff/1/mojo/go/sample_app/README.txt#newcode12 mojo/go/sample_app/README.txt:12: $ NDK_CC=$NDK_ROOT/bin/arm-linux-androideabi-gcc Why do you need all of this? ...
6 years, 1 month ago (2014-10-30 10:43:47 UTC) #4
gauthamt
https://codereview.chromium.org/647573004/diff/1/mojo/go/sample_app/README.txt File mojo/go/sample_app/README.txt (right): https://codereview.chromium.org/647573004/diff/1/mojo/go/sample_app/README.txt#newcode12 mojo/go/sample_app/README.txt:12: $ NDK_CC=$NDK_ROOT/bin/arm-linux-androideabi-gcc On 2014/10/30 10:43:47, qsr wrote: > Why ...
6 years, 1 month ago (2014-10-30 17:51:22 UTC) #5
jamesr
build/go is currently being snapshotted from chromium along with the rest of build/**, so any ...
6 years, 1 month ago (2014-10-30 22:20:44 UTC) #6
jamesr
Sorry, didn't realize this was still pending. READMEs lgtm
6 years, 1 month ago (2014-11-04 19:03:11 UTC) #7
gautham
6 years, 1 month ago (2014-11-04 19:06:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1a2084a2f46271a3b07f6e060d269314cbfd4405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698