Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 647573002: Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (Closed)

Created:
6 years, 2 months ago by jwd
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed (patchset #1 id:1 of https://codereview.chromium.org/644443002/) Reason for revert: Only cl that seems related to http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/6561 falures. Original issue's description: > ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed > > This problem manifests itself in simple Mojo apps that use NativeViewportService on X11. When the NativeViewport window is closed, the NativeViewportClient OnDestroyed() method does not run. > > BUG=421536 > > Committed: https://crrev.com/b37606e1c2a6703e58a61a978e8e32be72acae0c > Cr-Commit-Position: refs/heads/master@{#298926} TBR=ben@chromium.org,hansmuller@chromium.org NOTREECHECKS=true NOTRY=true BUG=421536 Committed: https://crrev.com/b93c31988a55a9cb2a328e39520f56788585b542 Cr-Commit-Position: refs/heads/master@{#298985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/platform_window/x11/x11_window.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jwd
Created Revert of ui::PlatformWindowDelegate::OnClosed() isn't called when a ui::X11Window is closed
6 years, 2 months ago (2014-10-09 21:37:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647573002/1
6 years, 2 months ago (2014-10-09 21:38:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 21:40:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b93c31988a55a9cb2a328e39520f56788585b542 Cr-Commit-Position: refs/heads/master@{#298985}
6 years, 2 months ago (2014-10-09 21:41:21 UTC) #4
brettw
6 years, 2 months ago (2014-10-09 22:37:52 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/642953003/ by brettw@chromium.org.

The reason for reverting is: This was not the cause of the regression. See
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

Powered by Google App Engine
This is Rietveld 408576698