Introduce AttachmentStore metadata record

sync/sync.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
 
   'includes': [
     'sync_android.gypi',
     'sync_tests.gypi',
   ],
 
   'targets': [
     # This target will add '-lsync_core' and '-lsync_proto' to the link line of
     # targets that depend on it.  Anything that depends on sync code should
     # declare a dependency on this target.
     {
       'target_name': 'sync',
       'type': 'none',
       'dependencies': [
         'sync_core',
         'sync_proto',
+        'attachment_store_proto',

[maniscalco, 2014/10/21 21:41:03]

sort order?

[pavely, 2014/10/24 20:42:55]

Done.

       ],
       'export_dependent_settings': [
         'sync_proto',
       ],
     },
 
     # Contains everything related to sync implementation that does not depend
     # on chrome/ or components/.  Do not depend on this directly.  Depend on
     # the 'sync' target to get the sync protobufs, too.
     {
@@ skipping 11 matching lines @@
         '../base/base.gyp:base_i18n',
         '../crypto/crypto.gyp:crypto',
         '../google_apis/google_apis.gyp:google_apis',
         '../net/net.gyp:net',
         '../sql/sql.gyp:sql',
         '../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
         '../third_party/protobuf/protobuf.gyp:protobuf_lite',
         '../third_party/zlib/zlib.gyp:zlib',
         '../url/url.gyp:url_lib',
         'sync_proto',
+        'attachment_store_proto',

[maniscalco, 2014/10/21 21:41:03]

sort order?

[pavely, 2014/10/24 20:42:55]

Done.

       ],
       'export_dependent_settings': [
         'sync_proto',
       ],
       'sources': [
         'api/attachments/attachment.cc',
         'api/attachments/attachment.h',
         'api/attachments/attachment_id.cc',
         'api/attachments/attachment_id.h',
         'api/attachments/attachment_store.cc',
@@ skipping 445 matching lines @@
         'enable_wexit_time_desctructors': 1,
         'proto_in_dir': './protocol',
         'proto_out_dir': 'sync/protocol',
         'cc_generator_options': 'dllexport_decl=SYNC_PROTO_EXPORT:',
         'cc_include': 'sync/protocol/sync_proto_export.h',
       },
       'includes': [
         '../build/protoc.gypi'
       ],
     },
+    {
+      # Contains attachment_store protobuf definitions.  Do not depend on this
+      # directly.
+      # Depend on the 'sync' target to get the relevant C++ code, too.
+      #
+      # GN version: //sync/internal_api/attachments/proto
+      'target_name': 'attachment_store_proto',
+      'type': '<(component)',
+      'sources': [
+        # NOTE: If you add a file to this list, also add it to
+        # sync/internal_api/attachments/proto/BUILD.gn
+        'internal_api/attachments/proto/attachment_store.proto',
+      ],
+      'variables': {
+        'enable_wexit_time_desctructors': 1,

[maniscalco, 2014/10/21 21:41:04]

Can you explain to me what this is for.  Is it necessary?

[pavely, 2014/10/24 20:42:55]

It enables "exit time destructors" warning. Allows to catch introduction of exit
time destructors at compile time.
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/FM8C-qPm5fk
https://code.google.com/p/chromium/issues/detail?id=101600

Entries in sync.gyp are misspelled. I'm fixing spelling.

[maniscalco, 2014/10/24 21:52:39]

Ah!  Cool.  I agree that we want this.  Good catch on the ones in sync.gyp.

+        'proto_in_dir': './internal_api/attachments/proto',

[maniscalco, 2014/10/21 21:41:04]

Is the leading ./ important?  In other gyp files, it seems like it's usually
omitted for proto_in_dir (enhanced_bookmarks being an exception).

[pavely, 2014/10/24 20:42:55]

Removed ./

+        'proto_out_dir': 'sync/internal_api/attachments/proto',
+      },
+      'includes': [
+        '../build/protoc.gypi'
+      ],
+    },
   ],
 }