Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 647553004: Mojo: Make room for remotely-allocated channel endpoint IDs. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@channel_endpoint_id_tests
Project:
chromium
Visibility:
Public.

Description

Mojo: Make room for remotely-allocated channel endpoint IDs. R=brettw@chromium.org Committed: https://crrev.com/fe92ab75a19d70d890e81c68cb3878da98480741 Cr-Commit-Position: refs/heads/master@{#299043}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : bah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M mojo/edk/system/channel_endpoint_id.h View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint_id.cc View 1 chunk +9 lines, -1 line 0 comments Download
M mojo/edk/system/channel_endpoint_id_unittest.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/638343003/, so please review that first.)
6 years, 2 months ago (2014-10-09 20:56:11 UTC) #1
brettw
lgtm
6 years, 2 months ago (2014-10-09 22:51:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647553004/60001
6 years, 2 months ago (2014-10-09 23:05:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647553004/310001
6 years, 2 months ago (2014-10-10 00:47:47 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:310001)
6 years, 2 months ago (2014-10-10 02:10:44 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:11:24 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fe92ab75a19d70d890e81c68cb3878da98480741
Cr-Commit-Position: refs/heads/master@{#299043}

Powered by Google App Engine
This is Rietveld 408576698