Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 647553003: Removes MediaDecoderJob virtual method call from destructor. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
qinmin, xhwang, ycheo (away)
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, byungchul, lcwu1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removes MediaDecoderJob virtual method call from destructor. This execution path is currently seen used when destroying a VideoDecoderJob that's still decoding: * MediaDecoderJob::Release (early return, destroy_pending_=true) * ... * MediaDecoderJob::OnDecodeComplete * ~VideoDecoderJob * ~MediaDecoderJob * MediaDecoderJob::ReleaseMediaCodecBridge * MediaDecoderJob::OnMediaCodecBridgeReleased <-- !!! The last line should be: * VideoDecoderJob::OnMediaCodecBridgeReleased but since it is invoked during the destructor the overridden implementation is not executed. R=qinmin@chromium.org,xhwang@chromium.org BUG=internal b/17671489 Committed: https://crrev.com/6a1f7b511cdcb590bcebb8371e880908fe592a22 Cr-Commit-Position: refs/heads/master@{#299159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/base/android/media_decoder_job.cc View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
gunsch
6 years, 2 months ago (2014-10-09 20:41:49 UTC) #1
gunsch
On 2014/10/09 20:41:49, gunsch wrote: xhwang@ just pointed out that this CL is silly @trunk ...
6 years, 2 months ago (2014-10-10 00:27:35 UTC) #2
gunsch
Reopened, +ycheo. Yuncheol pointed out that we should merge this to M37/M38 for android_webview. I ...
6 years, 2 months ago (2014-10-10 16:18:31 UTC) #4
qinmin
On 2014/10/10 16:18:31, gunsch wrote: > Reopened, +ycheo. > > Yuncheol pointed out that we ...
6 years, 2 months ago (2014-10-10 18:04:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647553003/1
6 years, 2 months ago (2014-10-10 18:26:38 UTC) #7
gunsch
Alright, I'll push this in for now. Yuncheol, what's the process for cherry-picking for android_webview? ...
6 years, 2 months ago (2014-10-10 18:33:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 19:21:35 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a1f7b511cdcb590bcebb8371e880908fe592a22 Cr-Commit-Position: refs/heads/master@{#299159}
6 years, 2 months ago (2014-10-10 19:22:25 UTC) #10
ycheo (away)
6 years, 2 months ago (2014-10-11 00:33:58 UTC) #11
Message was sent while issue was closed.
On 2014/10/10 18:33:15, gunsch wrote:
> Alright, I'll push this in for now.
> 
> Yuncheol, what's the process for cherry-picking for android_webview? This is
not
> easily testable using content shell or even Clank. Do you want to drive that?

Thanks for handling this.
Just cherry-picking to m37/m38 branch will apply to android_webview also.
I'll take the cherry-picking.

Powered by Google App Engine
This is Rietveld 408576698