Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 647553002: Revert of Use a single CGLContextObj to draw and update the IOSurface (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use a single CGLContextObj to draw and update the IOSurface (patchset #4 id:60001 of https://codereview.chromium.org/627003002/) Reason for revert: I hear reports of instability on Mac try servers, with crashes in the GL driver. Original issue's description: > Use a single CGLContextObj to draw and update the IOSurface > > There is no reason that this can't be done, based on documentation, > but it may be that this will cause crashes during texture destruction > or context tear-down (see crbug.com/411782). > > I have 3 theories as to why these crashes are occurring > 1. Using an IOSurface in a CGLContextObj that is also used by a > CAOpenGLLayer causes bugs > 2. The crashes observed were because context destruction just crashes > at a certain frequency, and previous patches made context destruction > more frequent. > 3. IOSurface-backed textures should be immutable -- no GL texture > should be bound to one IOSurface then the other. > > If theory 1 is correct, this will need to be reverted because the crashes > will re-occur. If theories 2 or 3 are correct, then this patch is safe. > > BUG=420253 > > Committed: https://crrev.com/0ea6e165293b7d24deec0d29fb9d6333d3a71b6d > Cr-Commit-Position: refs/heads/master@{#298916} TBR=kbr@chromium.org NOTREECHECKS=true NOTRY=true BUG=420253 Committed: https://crrev.com/4f30f97aa5185a61a3359fa55770b3dc64d62ea1 Cr-Commit-Position: refs/heads/master@{#298969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -46 lines) Patch
M content/browser/compositor/io_surface_context_mac.h View 2 chunks +22 lines, -9 lines 0 comments Download
M content/browser/compositor/io_surface_context_mac.mm View 4 chunks +41 lines, -17 lines 0 comments Download
M content/browser/compositor/io_surface_layer_mac.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/compositor/io_surface_layer_mac.mm View 4 chunks +12 lines, -7 lines 0 comments Download
M content/browser/compositor/io_surface_texture_mac.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/compositor/io_surface_texture_mac.mm View 5 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Use a single CGLContextObj to draw and update the IOSurface
6 years, 2 months ago (2014-10-09 20:35:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647553002/1
6 years, 2 months ago (2014-10-09 20:36:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 20:37:45 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:38:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f30f97aa5185a61a3359fa55770b3dc64d62ea1
Cr-Commit-Position: refs/heads/master@{#298969}

Powered by Google App Engine
This is Rietveld 408576698