Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 647543002: Adds web::NavigationItem. (Closed)

Created:
6 years, 2 months ago by rohitrao (ping after 24h)
Modified:
6 years, 2 months ago
Reviewers:
stuartmorgan, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds web::NavigationItem. This is the web/ analogue of content's NavigationEntry, intended for use on iOS because iOS cannot depend on content. NavigationItem captures all the data required to recreate a browsing state, such as URL, title, and transition type. BUG=422033 TEST=None Committed: https://crrev.com/cce127badb2d4150e8458921e393721c80b23981 Cr-Commit-Position: refs/heads/master@{#299093}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A + ios/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/public/navigation_item.h View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
rohitrao (ping after 24h)
+Scott to approve the ios/web -> ui dependency. +Stuart for the changes in ios/web. This ...
6 years, 2 months ago (2014-10-09 20:26:20 UTC) #2
stuartmorgan
LGTM, but could you flesh out the CL description a bit with some context for ...
6 years, 2 months ago (2014-10-09 20:39:35 UTC) #3
rohitrao (ping after 24h)
https://codereview.chromium.org/647543002/diff/1/ios/web/public/navigation_item.h File ios/web/public/navigation_item.h (right): https://codereview.chromium.org/647543002/diff/1/ios/web/public/navigation_item.h#newcode35 ios/web/public/navigation_item.h:35: virtual const base::string16& GetTitle() const = 0; On 2014/10/09 ...
6 years, 2 months ago (2014-10-09 20:52:53 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-10 02:39:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647543002/150001
6 years, 2 months ago (2014-10-10 11:45:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:150001)
6 years, 2 months ago (2014-10-10 11:48:35 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 11:49:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cce127badb2d4150e8458921e393721c80b23981
Cr-Commit-Position: refs/heads/master@{#299093}

Powered by Google App Engine
This is Rietveld 408576698