Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 647513002: Changed the menu item string for Relaunch in Chrome OS mode to Relaunch in Chrome immersive mode (Closed)

Created:
6 years, 2 months ago by ananta
Modified:
6 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5), candidodasilva92
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changed the menu item string for Relaunch in Chrome OS mode to Relaunch in Chrome immersive mode BUG=356475 Committed: https://crrev.com/dc202eb65cb8df448d6256e4c7dc0b7f97339b24 Cr-Commit-Position: refs/heads/master@{#298971}

Patch Set 1 #

Patch Set 2 : rebased to tip #

Patch Set 3 : Changed another Chrome OS mode string to Chrome immersive mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ananta
6 years, 2 months ago (2014-10-09 19:32:35 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 2 months ago (2014-10-09 19:35:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647513002/100001
6 years, 2 months ago (2014-10-09 19:36:59 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:100001)
6 years, 2 months ago (2014-10-09 20:40:00 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/dc202eb65cb8df448d6256e4c7dc0b7f97339b24 Cr-Commit-Position: refs/heads/master@{#298971}
6 years, 2 months ago (2014-10-09 20:40:55 UTC) #9
candidodasilva92_gmail.com
6 years, 2 months ago (2014-10-20 15:28:39 UTC) #10
Obrigado, e vou aplicar esses procedimento e volto a resposta OK.
Em quinta-feira, 9 de outubro de 2014 16h32min36s UTC-3, Anantanarayanan 
Iyengar escreveu:
>
> Reviewers: cpu, 
>
> Description: 
> Changed the menu item string for Relaunch in Chrome OS mode to Relaunch in 
> Chrome immersive mode 
>
> BUG=356475 
>
> Please review this at https://codereview.chromium.org/647513002/ 
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master 
>
> Affected files (+3, -3 lines): 
>    M chrome/app/generated_resources.grd 
>
>
> Index: chrome/app/generated_resources.grd 
> diff --git a/chrome/app/generated_resources.grd   
> b/chrome/app/generated_resources.grd 
> index   
>
d9a52a98d56851b435a8db2d39df06bd8402c08f..783b5faa77d5e43a2745ee400d331c93542c8653

>   
> 100644 
> --- a/chrome/app/generated_resources.grd 
> +++ b/chrome/app/generated_resources.grd 
> @@ -13957,12 +13957,12 @@ Do you accept? 
>           Relaunching in Windows 8 mode will close and relaunch your 
> Chrome   
> apps. 
>         </message> 
>         <message name="IDS_WIN_CHROMEOS_RESTART" 
> -               desc="Text for the menu item to restart Chrome in Chrome   
> OS. Applies to Windows 7 only"> 
> -        Relaunch Chrome in Chrome OS mode 
> +               desc="Text for the menu item to restart chrome in chrome   
> os. Aplies to Windows 7 only"> 
> +        Relaunch in Chrome immersive mode 
>         </message> 
>         <message name="IDS_WIN_PROMPT_TO_CLOSE_APPS_FOR_CHROMEOS" 
>                  desc="Modal message box prompt shown to the user after   
> requesting to relaunch in Windows Chrome OS mode while packaged apps are   
> running, which will require all packaged apps to be closed and then   
> restarted. Dialog is shown with choices: OK, Cancel."> 
> -        Relaunching in Chrome OS mode will close and relaunch your Chrome 
>   
> apps. 
> +        Relaunching in Chrome immersive mode will close and relaunch your 
>   
> Chrome apps. 
>         </message> 
>         <message name="IDS_WIN_PROMPT_TO_CLOSE_APPS_FOR_DESKTOP" 
>                  desc="Modal message box prompt shown to the user after   
> requesting to relaunch in Desktop mode while packaged apps are running,   
> which will require all packaged apps to be closed and then restarted.   
> Dialog is shown with choices: OK, Cancel."> 
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698