Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 647503002: Only unregister touch action handler conditionally (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reduced test case. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/fast/events/touch/touch-action-double-remove-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2315 matching lines...) Expand 10 before | Expand all | Expand 10 after
2326 cache->remove(this); 2326 cache->remove(this);
2327 2327
2328 // If this renderer had a parent, remove should have destroyed any counters 2328 // If this renderer had a parent, remove should have destroyed any counters
2329 // attached to this renderer and marked the affected other counters for 2329 // attached to this renderer and marked the affected other counters for
2330 // reevaluation. This apparently redundant check is here for the case when 2330 // reevaluation. This apparently redundant check is here for the case when
2331 // this renderer had no parent at the time remove() was called. 2331 // this renderer had no parent at the time remove() was called.
2332 2332
2333 if (hasCounterNodeMap()) 2333 if (hasCounterNodeMap())
2334 RenderCounter::destroyCounterNodes(*this); 2334 RenderCounter::destroyCounterNodes(*this);
2335 2335
2336 // Remove the handler if node had touch-action set. Don't call when 2336 // Remove the handler if node had touch-action set. Handlers are not added
2337 // document is being destroyed as all handlers will have been cleared 2337 // for text nodes so don't try removing for one too. Need to check if
2338 // previously. Handlers are not added for text nodes so don't try removing 2338 // m_style is null in cases of partial construction. Any handler we added
2339 // for one too. Need to check if m_style is null in cases of partial constru ction. 2339 // previously may have already been removed by the Document independently.
2340 if (!documentBeingDestroyed() && node() && !node()->isTextNode() && m_style && m_style->touchAction() != TouchActionAuto) 2340 if (node() && !node()->isTextNode() && m_style && m_style->touchAction() != TouchActionAuto) {
2341 document().frameHost()->eventHandlerRegistry().didRemoveEventHandler(*no de(), EventHandlerRegistry::TouchEvent); 2341 EventHandlerRegistry& registry = document().frameHost()->eventHandlerReg istry();
2342 if (registry.eventHandlerTargets(EventHandlerRegistry::TouchEvent)->cont ains(node()))
2343 registry.didRemoveEventHandler(*node(), EventHandlerRegistry::TouchE vent);
2344 }
2342 2345
2343 setAncestorLineBoxDirty(false); 2346 setAncestorLineBoxDirty(false);
2344 2347
2345 clearLayoutRootIfNeeded(); 2348 clearLayoutRootIfNeeded();
2346 } 2349 }
2347 2350
2348 void RenderObject::insertedIntoTree() 2351 void RenderObject::insertedIntoTree()
2349 { 2352 {
2350 // FIXME: We should ASSERT(isRooted()) here but generated content makes some out-of-order insertion. 2353 // FIXME: We should ASSERT(isRooted()) here but generated content makes some out-of-order insertion.
2351 2354
(...skipping 787 matching lines...) Expand 10 before | Expand all | Expand 10 after
3139 { 3142 {
3140 if (object1) { 3143 if (object1) {
3141 const blink::RenderObject* root = object1; 3144 const blink::RenderObject* root = object1;
3142 while (root->parent()) 3145 while (root->parent())
3143 root = root->parent(); 3146 root = root->parent();
3144 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3147 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3145 } 3148 }
3146 } 3149 }
3147 3150
3148 #endif 3151 #endif
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/touch/touch-action-double-remove-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698