Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 647503002: Only unregister touch action handler conditionally (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2349 matching lines...) Expand 10 before | Expand all | Expand 10 after
2360 cache->remove(this); 2360 cache->remove(this);
2361 2361
2362 // If this renderer had a parent, remove should have destroyed any counters 2362 // If this renderer had a parent, remove should have destroyed any counters
2363 // attached to this renderer and marked the affected other counters for 2363 // attached to this renderer and marked the affected other counters for
2364 // reevaluation. This apparently redundant check is here for the case when 2364 // reevaluation. This apparently redundant check is here for the case when
2365 // this renderer had no parent at the time remove() was called. 2365 // this renderer had no parent at the time remove() was called.
2366 2366
2367 if (hasCounterNodeMap()) 2367 if (hasCounterNodeMap())
2368 RenderCounter::destroyCounterNodes(*this); 2368 RenderCounter::destroyCounterNodes(*this);
2369 2369
2370 // Remove the handler if node had touch-action set. Don't call when 2370 // Remove the handler if node had touch-action set. Handlers are not added
2371 // document is being destroyed as all handlers will have been cleared 2371 // for text nodes so don't try removing for one too. Need to check if
2372 // previously. Handlers are not added for text nodes so don't try removing 2372 // m_style is null in cases of partial construction. Any handler we added
2373 // for one too. Need to check if m_style is null in cases of partial constru ction. 2373 // previously may have already been removed by the Document independently.
2374 if (!documentBeingDestroyed() && node() && !node()->isTextNode() && m_style && m_style->touchAction() != TouchActionAuto) 2374 if (node() && !node()->isTextNode() && m_style && m_style->touchAction() != TouchActionAuto) {
2375 document().frameHost()->eventHandlerRegistry().didRemoveEventHandler(*no de(), EventHandlerRegistry::TouchEvent); 2375 EventHandlerRegistry& registry = document().frameHost()->eventHandlerReg istry();
2376 if (registry.eventHandlerTargets(EventHandlerRegistry::TouchEvent)->cont ains(node()))
2377 registry.didRemoveEventHandler(*node(), EventHandlerRegistry::TouchE vent);
2378 }
2376 2379
2377 setAncestorLineBoxDirty(false); 2380 setAncestorLineBoxDirty(false);
2378 2381
2379 clearLayoutRootIfNeeded(); 2382 clearLayoutRootIfNeeded();
2380 } 2383 }
2381 2384
2382 void RenderObject::insertedIntoTree() 2385 void RenderObject::insertedIntoTree()
2383 { 2386 {
2384 // FIXME: We should ASSERT(isRooted()) here but generated content makes some out-of-order insertion. 2387 // FIXME: We should ASSERT(isRooted()) here but generated content makes some out-of-order insertion.
2385 2388
(...skipping 787 matching lines...) Expand 10 before | Expand all | Expand 10 after
3173 { 3176 {
3174 if (object1) { 3177 if (object1) {
3175 const blink::RenderObject* root = object1; 3178 const blink::RenderObject* root = object1;
3176 while (root->parent()) 3179 while (root->parent())
3177 root = root->parent(); 3180 root = root->parent();
3178 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3181 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3179 } 3182 }
3180 } 3183 }
3181 3184
3182 #endif 3185 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698