Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 6475006: Refactoring codegen for delete. (Closed)

Created:
9 years, 10 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactoring codegen for delete. * keep handling of VariableProxy and Property together * place clauses in the order of discovery The refactoring is inspired by the strict mode delete changes. While placing the ASSERT(strict_mode_flag() == kNonStrictMode) for the variable case, I realized that better order of the if clauses would make the code more readable, and also make it eas to place my assert. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -74 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +27 lines, -26 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +25 lines, -24 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Martin Maly
While working on the strict mode delete I found that I can reorder the if ...
9 years, 10 months ago (2011-02-14 06:03:21 UTC) #1
Kevin Millikin (Chromium)
9 years, 10 months ago (2011-02-14 06:45:58 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698