Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: build/common.gypi

Issue 647483004: Do not use zero or empty android:versionCode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update GN as well. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1398 matching lines...) Expand 10 before | Expand all | Expand 10 after
1409 1409
1410 # Whether to build full debug version for Debug configuration on Android. 1410 # Whether to build full debug version for Debug configuration on Android.
1411 # Compared to full debug version, the default Debug configuration on Android 1411 # Compared to full debug version, the default Debug configuration on Android
1412 # has no full v8 debug, has size optimization and linker gc section, so that 1412 # has no full v8 debug, has size optimization and linker gc section, so that
1413 # we can build a debug version with acceptable size and performance. 1413 # we can build a debug version with acceptable size and performance.
1414 'android_full_debug%': 0, 1414 'android_full_debug%': 0,
1415 1415
1416 # Sets the default version name and code for Android app, by default we 1416 # Sets the default version name and code for Android app, by default we
1417 # do a developer build. 1417 # do a developer build.
1418 'android_app_version_name%': 'Developer Build', 1418 'android_app_version_name%': 'Developer Build',
1419 'android_app_version_code%': 0, 1419 'android_app_version_code%': 1,
1420 1420
1421 # Contains data about the attached devices for gyp_managed_install. 1421 # Contains data about the attached devices for gyp_managed_install.
1422 'build_device_config_path': '<(PRODUCT_DIR)/build_devices.cfg', 1422 'build_device_config_path': '<(PRODUCT_DIR)/build_devices.cfg',
1423 1423
1424 'sas_dll_exists': '<!pymod_do_main(dir_exists "<(sas_dll_path)")', 1424 'sas_dll_exists': '<!pymod_do_main(dir_exists "<(sas_dll_path)")',
1425 'wix_exists': '<!pymod_do_main(dir_exists "<(wix_path)")', 1425 'wix_exists': '<!pymod_do_main(dir_exists "<(wix_path)")',
1426 1426
1427 'windows_sdk_default_path': '<(DEPTH)/third_party/platformsdk_win8/files', 1427 'windows_sdk_default_path': '<(DEPTH)/third_party/platformsdk_win8/files',
1428 'directx_sdk_default_path': '<(DEPTH)/third_party/directxsdk/files', 1428 'directx_sdk_default_path': '<(DEPTH)/third_party/directxsdk/files',
1429 1429
(...skipping 4281 matching lines...) Expand 10 before | Expand all | Expand 10 after
5711 # settings in target dicts. SYMROOT is a special case, because many other 5711 # settings in target dicts. SYMROOT is a special case, because many other
5712 # Xcode variables depend on it, including variables such as 5712 # Xcode variables depend on it, including variables such as
5713 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5713 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5714 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5714 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5715 # files to appear (when present) in the UI as actual files and not red 5715 # files to appear (when present) in the UI as actual files and not red
5716 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5716 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5717 # and therefore SYMROOT, needs to be set at the project level. 5717 # and therefore SYMROOT, needs to be set at the project level.
5718 'SYMROOT': '<(DEPTH)/xcodebuild', 5718 'SYMROOT': '<(DEPTH)/xcodebuild',
5719 }, 5719 },
5720 } 5720 }
OLDNEW
« no previous file with comments | « no previous file | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698