test/NaCl/X86/nacl-read-tp-intrinsic.ll - Issue 647443005: Change usage of naclcall and nacljmp pseudo-instructions to match x86 gas

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/NaCl/X86/nacl-read-tp-intrinsic.ll

Issue 647443005: Change usage of naclcall and nacljmp pseudo-instructions to match x86 gas (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: remove NACL_call32d and auto-align bare call Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« lib/Target/X86/X86NaClRewritePass.cpp ('K') | « test/NaCl/X86/nacl-calls.ll ('k') | test/NaCl/X86/nacl-setlongjmp-intrinsics.ll » ('j') | no next file with comments »

OLD	NEW
1 ; RUN: pnacl-llc -mtriple=i386-unknown-nacl -filetype=asm %s -o - \	1 ; RUN: pnacl-llc -mtriple=i386-unknown-nacl -filetype=asm %s -o - \

2 ; RUN: \| FileCheck -check-prefix=X32 %s	2 ; RUN: \| FileCheck -check-prefix=X32 %s

3	3

4 ; RUN: pnacl-llc -mtriple=i386-unknown-nacl -filetype=asm -mtls-use-call %s -o - \	4 ; RUN: pnacl-llc -mtriple=i386-unknown-nacl -filetype=asm -mtls-use-call %s -o - \

5 ; RUN: \| FileCheck -check-prefix=USE_CALL %s	5 ; RUN: \| FileCheck -check-prefix=USE_CALL %s

6	6

7 ; RUN: pnacl-llc -mtriple=x86_64-unknown-nacl -filetype=asm %s -o - \	7 ; RUN: pnacl-llc -mtriple=x86_64-unknown-nacl -filetype=asm %s -o - \

8 ; RUN: \| FileCheck -check-prefix=USE_CALL %s	8 ; RUN: \| FileCheck -check-prefix=USE_CALL %s

9	9

10 ; "-mtls-use-call" should not make any difference on x86-64.	10 ; "-mtls-use-call" should not make any difference on x86-64.

11 ; RUN: pnacl-llc -mtriple=x86_64-unknown-nacl -filetype=asm -mtls-use-call %s -o - \	11 ; RUN: pnacl-llc -mtriple=x86_64-unknown-nacl -filetype=asm -mtls-use-call %s -o - \

12 ; RUN: \| FileCheck -check-prefix=USE_CALL %s	12 ; RUN: \| FileCheck -check-prefix=USE_CALL %s

13	13

14	14

15 declare i8* @llvm.nacl.read.tp()	15 declare i8* @llvm.nacl.read.tp()

16	16

17 define i8* @get_thread_pointer() {	17 define i8* @get_thread_pointer() {

18 %tp = call i8* @llvm.nacl.read.tp()	18 %tp = call i8* @llvm.nacl.read.tp()

19 ret i8* %tp	19 ret i8* %tp

20 }	20 }

21	21

22 ; X32: get_thread_pointer:	22 ; X32: get_thread_pointer:

23 ; X32: movl %gs:0, %eax	23 ; X32: movl %gs:0, %eax

24	24

25 ; USE_CALL: get_thread_pointer:	25 ; USE_CALL: get_thread_pointer:

26 ; USE_CALL: naclcall __nacl_read_tp	26 ; USE_CALL: call{{l?}} __nacl_read_tp

27	27

28	28

29 ; Make sure that we do not generate:	29 ; Make sure that we do not generate:

30 ; movl $1000, %eax	30 ; movl $1000, %eax

31 ; addl %gs:0, %eax	31 ; addl %gs:0, %eax

32 ; The x86-32 NaCl validator only accepts %gs with "mov", not with	32 ; The x86-32 NaCl validator only accepts %gs with "mov", not with

33 ; "add". Note that we had to use a large immediate to trigger the bug	33 ; "add". Note that we had to use a large immediate to trigger the bug

34 ; and generate the code above.	34 ; and generate the code above.

35 define i8* @get_thread_pointer_add() {	35 define i8* @get_thread_pointer_add() {

36 %tp = call i8* @llvm.nacl.read.tp()	36 %tp = call i8* @llvm.nacl.read.tp()

37 %result = getelementptr i8* %tp, i32 1000	37 %result = getelementptr i8* %tp, i32 1000

38 ret i8* %result	38 ret i8* %result

39 }	39 }

40	40

41 ; X32: get_thread_pointer_add:	41 ; X32: get_thread_pointer_add:

42 ; X32: movl %gs:0, %eax	42 ; X32: movl %gs:0, %eax

43 ; X32: addl $1000, %eax	43 ; X32: addl $1000, %eax

OLD	NEW