Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 647433003: Convert GpuBenchmarkingExtension to a gin::Wrappable class (Closed)

Created:
6 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 2 months ago
Reviewers:
nduca, ernstm
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, hajimehoshi, jam, kouhei (in TOK), mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert GpuBenchmarkingExtension to a gin::Wrappable class v8 extensions are slowing down context creation and we're trying to get rid of them. BUG=334679 R=ernstm@chromium.org,nduca@chromium.org Committed: https://crrev.com/26f63992473dda66e4ed2b22f35d4ccd0702ddcd Cr-Commit-Position: refs/heads/master@{#300957}

Patch Set 1 #

Patch Set 2 : updatres #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -672 lines) Patch
M content/renderer/gpu/gpu_benchmarking_extension.h View 1 1 chunk +46 lines, -4 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 5 chunks +552 lines, -665 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
jochen (gone - plz use gerrit)
ptal looks scary, but it's really only moving the handling of optional arguments from JS ...
6 years, 2 months ago (2014-10-09 14:57:01 UTC) #1
jochen (gone - plz use gerrit)
I ran smoothness.top_25 locally and that seems to work. Is there a way to trigger ...
6 years, 2 months ago (2014-10-09 14:58:34 UTC) #2
jochen (gone - plz use gerrit)
On 2014/10/09 at 14:58:34, jochen wrote: > I ran smoothness.top_25 locally and that seems to ...
6 years, 2 months ago (2014-10-09 15:09:34 UTC) #3
jochen (gone - plz use gerrit)
I guess the regular trybots already exercise some of this, and I still have some ...
6 years, 2 months ago (2014-10-09 18:20:35 UTC) #4
ernstm
On 2014/10/09 18:20:35, jochen wrote: > I guess the regular trybots already exercise some of ...
6 years, 2 months ago (2014-10-09 21:41:27 UTC) #5
jochen (gone - plz use gerrit)
+hajimehoshi/kouhei fyi about crbug.com422244
6 years, 2 months ago (2014-10-10 09:42:30 UTC) #6
jochen (gone - plz use gerrit)
ptal I checked with kouhei that disabling the inspector test is ok until the underlying ...
6 years, 2 months ago (2014-10-22 07:54:20 UTC) #7
ernstm
On 2014/10/22 07:54:20, jochen (OOO real soon now) wrote: > ptal > > I checked ...
6 years, 2 months ago (2014-10-23 20:44:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647433003/160001
6 years, 2 months ago (2014-10-23 20:50:05 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:160001)
6 years, 2 months ago (2014-10-23 22:00:09 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 22:00:57 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/26f63992473dda66e4ed2b22f35d4ccd0702ddcd
Cr-Commit-Position: refs/heads/master@{#300957}

Powered by Google App Engine
This is Rietveld 408576698