Oilpan: Forbid adoptRef(X*) where X is RefCountedGarbageCollected

Source/wtf/PassRefPtr.h

Index: Source/wtf/PassRefPtr.h
diff --git a/Source/wtf/PassRefPtr.h b/Source/wtf/PassRefPtr.h
index a099eef5aa35ca287fa50971a04da5e4b812829d..d3e613ee978edf1d294bad406e0355d7d0460d8f 100644
--- a/Source/wtf/PassRefPtr.h
+++ b/Source/wtf/PassRefPtr.h
@@ -26,6 +26,10 @@
 #include "wtf/RawPtr.h"
 #include "wtf/TypeTraits.h"
 
+namespace blink {
+template<typename T> class RefCountedGarbageCollected;
+}
+
 namespace WTF {
 
     template<typename T> class RefPtr;
@@ -185,6 +189,8 @@ namespace WTF {
 
     template<typename T> PassRefPtr<T> adoptRef(T* p)
     {
+        static const bool notRefCountedGarbageCollected = !WTF::IsSubclassOfTemplate<typename WTF::RemoveConst<T>::Type, blink::RefCountedGarbageCollected>::value;
+        COMPILE_ASSERT(notRefCountedGarbageCollected, adoptRefIsNotAllowedForRefCountedGarbageCollected);

[Mikhail, 2014/10/14 11:05:10]

wouldn't smth like 

template<T> void adoptRef(const RefCountedGarbageCollected<T>*)
{
  static_assert(false, ...);
}

be better? 
(btw this can be put together with the RefCountedGarbageCollected declaration)

[tkent, 2014/11/10 06:06:59]

Mikhail's idea looks better.
This patch has a layering violation.  WTF should have no knowledge of
blink::RefCountedGarbageCollected.

[haraken, 2014/11/10 06:41:56]

Hmm, it looks like I need your help.

When I add:

  template<typename T>
  PassRefPtr<T> adoptRef(RefCountedGarbageCollected<T>*)
  {
    COMPILE_ASSERT(false, ...);
  }

to Handle.h, I always hit the assert when including Handle.h, like this:

In file included from
../../third_party/WebKit/Source/web/painting/ContinuousPainter.cpp:33:
In file included from
../../third_party/WebKit/Source/platform/graphics/GraphicsLayer.h:38:
In file included from
../../third_party/WebKit/Source/platform/graphics/GraphicsLayerDebugInfo.h:39:
In file included from
../../third_party/WebKit/public/platform/WebGraphicsLayerDebugInfo.h:34:
In file included from ../../third_party/WebKit/public/platform/WebString.h:35:
In file included from
../../third_party/WebKit/public/platform/WebPrivatePtr.h:37:
../../third_party/WebKit/Source/platform/heap/Handle.h:967:5: error:
static_assert failed "adoptRefIsNotAllowedForRefCountedGarbageCollected"
    COMPILE_ASSERT(false, adoptRefIsNotAllowedForRefCountedGarbageCollected);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

How can I avoid hitting the assert?

[Mikhail, 2014/11/10 10:10:57]

yeah, sorry this trick does not work with functions, it's compiled even if it's
not used :( The easy solution which I've on top of my head is

template<typename T>
PassRefPtr<T> adoptRef(RefCountedGarbageCollected<T>*) = delete;

         adopted(p);
         return PassRefPtr<T>(p, PassRefPtr<T>::AdoptRef);
     }