Oilpan: Forbid adoptRef(X*) where X is RefCountedGarbageCollected

Source/core/rendering/RenderLayerClipper.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 95 matching lines @@
     // We should add a test that has an inconsistent root. See
     // http://crbug.com/366118 for an example.
     if (context.rootLayer != entry.root)
         return 0;
     ASSERT(entry.scrollbarRelevancy == context.scrollbarRelevancy);
 
 #ifdef CHECK_CACHED_CLIP_RECTS
     // This code is useful to check cached clip rects, but is too expensive to leave enabled in debug builds by default.
     ClipRectsContext tempContext(context);
     tempContext.cacheSlot = UncachedClipRects;
-    ClipRects clipRects;
-    calculateClipRects(tempContext, clipRects);
+    RefPtr<ClipRects> clipRects = ClipRects::create();
+    calculateClipRects(tempContext, *clipRects);
     ASSERT(clipRects == *entry.clipRects);
 #endif
 
     return entry.clipRects.get();
 }
 
 ClipRects* RenderLayerClipper::storeClipRectsInCache(const ClipRectsContext& context, ClipRects* parentClipRects, const ClipRects& clipRects) const
 {
     ClipRectsCache::Entry& entry = cache().get(context.cacheSlot);
     entry.root = context.rootLayer;
@@ skipping 18 matching lines @@
     if (ClipRects* result = clipRectsIfCached(context))
         return result;
 
     // Note that it's important that we call getClipRects on our parent
     // before we call calculateClipRects so that calculateClipRects will hit
     // the cache.
     ClipRects* parentClipRects = 0;
     if (context.rootLayer != m_renderer.layer() && m_renderer.layer()->parent())
         parentClipRects = m_renderer.layer()->parent()->clipper().getClipRects(context);
 
-    ClipRects clipRects;
-    calculateClipRects(context, clipRects);
-    return storeClipRectsInCache(context, parentClipRects, clipRects);
+    RefPtr<ClipRects> clipRects = ClipRects::create();
+    calculateClipRects(context, *clipRects);
+    return storeClipRectsInCache(context, parentClipRects, *clipRects);
 }
 
 void RenderLayerClipper::clearClipRectsIncludingDescendants()
 {
     m_cache = nullptr;
 
     for (RenderLayer* layer = m_renderer.layer()->firstChild(); layer; layer = layer->nextSibling())
         layer->clipper().clearClipRectsIncludingDescendants();
 }
 
@@ skipping 149 matching lines @@
         return parentRects.posClipRect();
 
     return parentRects.overflowClipRect();
 }
 
 ClipRect RenderLayerClipper::backgroundClipRect(const ClipRectsContext& context) const
 {
     ASSERT(m_renderer.layer()->parent());
     ASSERT(m_renderer.view());
 
-    ClipRects parentClipRects;
+    RefPtr<ClipRects> parentClipRects = ClipRects::create();
     if (m_renderer.layer() == context.rootLayer)
-        parentClipRects.reset(PaintInfo::infiniteRect());
+        parentClipRects->reset(PaintInfo::infiniteRect());
     else
-        m_renderer.layer()->parent()->clipper().getOrCalculateClipRects(context, parentClipRects);
+        m_renderer.layer()->parent()->clipper().getOrCalculateClipRects(context, *parentClipRects);
 
-    ClipRect result = backgroundClipRectForPosition(parentClipRects, m_renderer.style()->position());
+    ClipRect result = backgroundClipRectForPosition(*parentClipRects, m_renderer.style()->position());
 
     // Note: infinite clipRects should not be scrolled here, otherwise they will accidentally no longer be considered infinite.
-    if (parentClipRects.fixed() && context.rootLayer->renderer() == m_renderer.view() && result != PaintInfo::infiniteRect())
+    if (parentClipRects->fixed() && context.rootLayer->renderer() == m_renderer.view() && result != PaintInfo::infiniteRect())
         result.move(m_renderer.view()->frameView()->scrollOffsetForFixedPosition());
 
     return result;
 }
 
 void RenderLayerClipper::getOrCalculateClipRects(const ClipRectsContext& context, ClipRects& clipRects) const
 {
     if (context.usesCache())
         clipRects = *getClipRects(context);
     else
@@ skipping 18 matching lines @@
         ASSERT(current);
         if (current->transform() || current->isPaintInvalidationContainer())
             return const_cast<RenderLayer*>(current);
     }
 
     ASSERT_NOT_REACHED();
     return 0;
 }
 
 } // namespace blink