Issue 647383002: [Speculative revert to fix browser_tests on Blink canaries.]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647383002: [Speculative revert to fix browser_tests on Blink canaries.] (Closed)

Created:
6 years, 2 months ago by Stephen White

Modified:
6 years, 2 months ago

Reviewers:
sandersd (OOO until July 31)

CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, philipj_slow, eric.carlson_apple.com, mkwst+moarreviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

[Speculative revert to fix browser_tests on Blink canaries.] Revert "Remove "needkey" event and add it's replacement, "encrypted"." This reverts commit ad09c3ed1914691ee4a089cfe95988892ed42407. BUG= TBR=sandersd Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183580

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -326 lines)			Patch
M	LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload.html	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-lifetime-reload-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	LayoutTests/media/encrypted-media/encrypted-media-needkey.html	View	3 chunks	+8 lines, -9 lines	0 comments	Download
A	LayoutTests/media/encrypted-media/encrypted-media-needkey-expected.txt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
D	LayoutTests/media/encrypted-media/encrypted-media-onencrypted.html	View	1 chunk	+0 lines, -40 lines	0 comments	Download
D	LayoutTests/media/encrypted-media/encrypted-media-onencrypted-expected.txt	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions.html	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-playback-multiple-sessions-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-after-src.html	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-after-src-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src.html	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-v2-syntax.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-waiting-for-a-key.html	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-waiting-for-a-key-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/prefixed/encrypted-media-events.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/prefixed/encrypted-media-events-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/events/EventTypeNames.in	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp	View	3 chunks	+12 lines, -14 lines	0 comments	Download
M	Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/modules/encryptedmedia/MediaEncryptedEvent.h	View	1 chunk	+0 lines, -73 lines	0 comments	Download
D	Source/modules/encryptedmedia/MediaEncryptedEvent.cpp	View	1 chunk	+0 lines, -60 lines	0 comments	Download
D	Source/modules/encryptedmedia/MediaEncryptedEvent.idl	View	1 chunk	+0 lines, -33 lines	0 comments	Download
A +	Source/modules/encryptedmedia/MediaKeyNeededEvent.h	View	1 chunk	+20 lines, -20 lines	0 comments	Download
A +	Source/modules/encryptedmedia/MediaKeyNeededEvent.cpp	View	1 chunk	+11 lines, -9 lines	0 comments	Download
A +	Source/modules/encryptedmedia/MediaKeyNeededEvent.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/modules.gypi	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/web/WebMediaPlayerClientImpl.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	public/platform/WebMediaPlayerClient.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Committed patchset #1 (id:1) manually as 183580 (presubmit successful).

6 years, 2 months ago (2014-10-12 14:39:28 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages