Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 647343004: Only send TTS VoicesChanged callbacks when TTS has been explicitly requested. (Closed)

Created:
6 years, 2 months ago by David Tseng
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Only send TTS VoicesChanged callbacks when TTS has been explicitly requested. BUG=417106 TEST=none Committed: https://crrev.com/2c1bb701074fb000f442e724dc6c383ffaca471e Cr-Commit-Position: refs/heads/master@{#299894}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/speech/tts_controller_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
David Tseng
6 years, 2 months ago (2014-10-16 00:13:10 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-16 06:26:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647343004/20001
6 years, 2 months ago (2014-10-16 06:27:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64011)
6 years, 2 months ago (2014-10-16 07:21:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647343004/20001
6 years, 2 months ago (2014-10-16 14:53:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 14:53:52 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 14:54:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c1bb701074fb000f442e724dc6c383ffaca471e
Cr-Commit-Position: refs/heads/master@{#299894}

Powered by Google App Engine
This is Rietveld 408576698