Source/web/WebViewImpl.cpp - Issue 647343003: Fix crash with fullscreen elements inside frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 647343003: Fix crash with fullscreen elements inside frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add assertion Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index fac62137f762205fd29b99d451e434b7d106d404..91352073460b903d6e7171c1f02bc36e38fcbe70 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -81,7 +81,6 @@

#include "core/page/PointerLockController.h"

#include "core/page/ScopedPageLoadDeferrer.h"

#include "core/page/TouchDisambiguation.h"

-#include "core/rendering/RenderFullScreen.h"

#include "core/rendering/RenderPart.h"

#include "core/rendering/RenderView.h"

#include "core/rendering/TextAutosizer.h"

@@ -1759,8 +1758,7 @@ void WebViewImpl::resize(const WebSize& newSize)

performResize();

}

- if (m_fullscreenController->isFullscreen())

- Fullscreen::from(*view->frame().document()).fullScreenRenderer()->updateStyle();

+ m_fullscreenController->updateSize();

if (settings()->viewportEnabled()) {

// Relayout immediately to recalculate the minimum scale limit.

« no previous file with comments | « Source/web/FullscreenController.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »