runtime/vm/stub_code_arm.cc - Issue 64723002: VM: Fix identical comparisons with bigints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 64723002: VM: Fix identical comparisons with bigints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: fixed MIPS Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_arm.cc

===================================================================

--- runtime/vm/stub_code_arm.cc (revision 30047)

+++ runtime/vm/stub_code_arm.cc (working copy)

@@ -2124,8 +2124,7 @@

}

-// Called from otpimzied code only. Must preserve any registers that are

-// destroyed.

+// Called from optimized code only.

// LR: return address.

// SP + 4: left operand.

// SP + 0: right operand.

@@ -2135,12 +2134,9 @@

const Register temp = R2;

const Register left = R1;

const Register right = R0;

- // Preserve left, right and temp.

- __ PushList((1 << R0) | (1 << R1) | (1 << R2));

- __ ldr(left, Address(SP, 4 * kWordSize));

- __ ldr(right, Address(SP, 3 * kWordSize));

+ __ ldr(left, Address(SP, 1 * kWordSize));

+ __ ldr(right, Address(SP, 0 * kWordSize));

GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp);

- __ PopList((1 << R0) | (1 << R1) | (1 << R2));

__ Ret();

}

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »