Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 64723002: VM: Fix identical comparisons with bigints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed MIPS Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 4629 matching lines...) Expand 10 before | Expand all | Expand 10 after
4640 4640
4641 4641
4642 void CurrentContextInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 4642 void CurrentContextInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
4643 __ MoveRegister(locs()->out().reg(), CTX); 4643 __ MoveRegister(locs()->out().reg(), CTX);
4644 } 4644 }
4645 4645
4646 4646
4647 LocationSummary* StrictCompareInstr::MakeLocationSummary() const { 4647 LocationSummary* StrictCompareInstr::MakeLocationSummary() const {
4648 const intptr_t kNumInputs = 2; 4648 const intptr_t kNumInputs = 2;
4649 const intptr_t kNumTemps = 0; 4649 const intptr_t kNumTemps = 0;
4650 if (needs_number_check()) {
4651 LocationSummary* locs =
4652 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
4653 locs->set_in(0, Location::RegisterLocation(EAX));
4654 locs->set_in(1, Location::RegisterLocation(ECX));
4655 locs->set_out(Location::RegisterLocation(EAX));
4656 return locs;
4657 }
4650 LocationSummary* locs = 4658 LocationSummary* locs =
4651 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall); 4659 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
4652 locs->set_in(0, Location::RegisterOrConstant(left())); 4660 locs->set_in(0, Location::RegisterOrConstant(left()));
4653 locs->set_in(1, Location::RegisterOrConstant(right())); 4661 locs->set_in(1, Location::RegisterOrConstant(right()));
4654 locs->set_out(Location::RequiresRegister()); 4662 locs->set_out(Location::RequiresRegister());
4655 return locs; 4663 return locs;
4656 } 4664 }
4657 4665
4658 4666
4659 // Special code for numbers (compare values instead of references.) 4667 // Special code for numbers (compare values instead of references.)
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
4944 PcDescriptors::kOther, 4952 PcDescriptors::kOther,
4945 locs()); 4953 locs());
4946 __ Drop(2); // Discard type arguments and receiver. 4954 __ Drop(2); // Discard type arguments and receiver.
4947 } 4955 }
4948 4956
4949 } // namespace dart 4957 } // namespace dart
4950 4958
4951 #undef __ 4959 #undef __
4952 4960
4953 #endif // defined TARGET_ARCH_IA32 4961 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698