Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 647223002: Remove unused paintScrollbarThumb impl. (Closed)

Created:
6 years, 2 months ago by skobes
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, ccameron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unused Mac implementation of paintScrollbarThumb. WebThemeEngine::paintScrollbarThumb is no longer called by Blink since http://crrev.com/544913002. BUG=327471 Committed: https://crrev.com/ec857a14cb939730c846a2bfe6ae508a20b83eb2 Cr-Commit-Position: refs/heads/master@{#299237}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -305 lines) Patch
M content/child/webthemeengine_impl_mac.h View 1 chunk +0 lines, -8 lines 0 comments Download
D content/child/webthemeengine_impl_mac.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_theme_engine.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_theme_engine.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
D content/shell/renderer/test_runner/mock_web_theme_engine_mac.h View 1 chunk +0 lines, -46 lines 0 comments Download
D content/shell/renderer/test_runner/mock_web_theme_engine_mac.mm View 1 chunk +0 lines, -170 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.h View 1 2 chunks +1 line, -10 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
skobes
6 years, 2 months ago (2014-10-10 22:57:05 UTC) #2
skobes
Oops... hold off on reviewing this.
6 years, 2 months ago (2014-10-10 22:58:42 UTC) #3
skobes
Ok this is ready for review.
6 years, 2 months ago (2014-10-10 23:52:43 UTC) #6
Avi (use Gerrit)
lgtm rrreeeedddd
6 years, 2 months ago (2014-10-11 03:08:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647223002/210001
6 years, 2 months ago (2014-10-11 03:46:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/23130)
6 years, 2 months ago (2014-10-11 04:55:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647223002/210001
6 years, 2 months ago (2014-10-11 04:58:27 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:210001)
6 years, 2 months ago (2014-10-11 06:05:08 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 06:05:52 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec857a14cb939730c846a2bfe6ae508a20b83eb2
Cr-Commit-Position: refs/heads/master@{#299237}

Powered by Google App Engine
This is Rietveld 408576698