Issue 647203002: * libc/posix/posix_spawn.c: include _syslist.h. This allows it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647203002: * libc/posix/posix_spawn.c: include _syslist.h. This allows it (Closed)

Created:
6 years, 2 months ago by Sam Clegg

Modified:
6 years, 2 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master

Visibility:
Public.

* libc/posix/posix_spawn.c: include _syslist.h. This allows it to be used when MISSING_SYSCALL_NAMES is defined. Without this references to _open and _close are generated which are not available when MISSING_SYSCALL_NAMES is defined. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3976 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3973 R=binji@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=a59cc12d1126284dff3b7bb0e361dae944f140fc

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	newlib/libc/posix/posix_spawn.c	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Sam Clegg

Without this change any code that references a posix_spawn_* function will generate undefined symbols.

6 years, 2 months ago (2014-10-10 21:59:17 UTC) #2

Sam Clegg

6 years, 2 months ago (2014-10-13 16:47:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a59cc12d1126284dff3b7bb0e361dae944f140fc (presubmit successful).