Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 647193005: Merge codereview.chromium.org/630243002 onto 2171 branch (Closed)

Created:
6 years, 2 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/2171
Project:
chromium
Visibility:
Public.

Description

Merge codereview.chromium.org/630243002 onto 2171 branch Fix extension content verification handling of ./ in icon paths When extension manifests contain icon paths with a leading ./, we were failing to process them properly BUG=410666 Review URL: https://codereview.chromium.org/630243002 Cr-Commit-Position: refs/heads/master@{#298979} (cherry picked from commit 7cc29ce343a235f9067545ddd19ba2d982c4595f) Conflicts: chrome/browser/extensions/content_verifier_browsertest.cc Committed: https://chromium.googlesource.com/chromium/src/+/84286ec445962cc0c7feca0eeff96a3155ce17d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -20 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 4 chunks +114 lines, -8 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths.crx View Binary file 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/_metadata/verified_contents.json View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/content_verifier/dot_slash_paths/background.js View 1 chunk +4 lines, -4 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/dir/page2.html View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/icon.png View Binary file 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/icon2.png View Binary file 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/icon3.png View Binary file 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/img/test/icon4.png View Binary file 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/img/test/icon5.png View Binary file 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/manifest.json View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/content_verifier/dot_slash_paths/page.html View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/content_verifier/dot_slash_paths/page.js View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/content_verifier/dot_slash_paths/page2.js View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/content_verifier.cc View 4 chunks +37 lines, -2 lines 0 comments Download
M extensions/browser/content_verifier_io_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/content_verifier_io_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/content_verify_job.h View 1 chunk +11 lines, -0 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 5 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
asargent_no_longer_on_chrome
6 years, 2 months ago (2014-10-21 20:31:38 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84286ec445962cc0c7feca0eeff96a3155ce17d6.

Powered by Google App Engine
This is Rietveld 408576698