Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 647193004: Install lib64stdc++ in install-chroot.sh. (Closed)

Created:
6 years, 2 months ago by Yoshisato Yanagisawa
Modified:
6 years, 2 months ago
Reviewers:
Junichi Uekawa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Install lib64stdc++ in install-chroot.sh. Install lib64stdc++ to be used by 64bit goma inside 32bit env. BUG=https://code.google.com/p/chromium/issues/detail?id=409482 Committed: https://crrev.com/dc73b4aa729c20d70540a5fe1411b2100a488450 Cr-Commit-Position: refs/heads/master@{#300080}

Patch Set 1 #

Patch Set 2 : moved to more appropriate location #

Total comments: 2

Patch Set 3 : use lib64stdc++6 instead of libstdc++6:amd64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-chroot.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Yoshisato Yanagisawa
Hi, How about the solution like this? If we do not think about supporting very ...
6 years, 2 months ago (2014-10-17 05:20:59 UTC) #2
Yoshisato Yanagisawa
As we talked offline, I have moved the installing of libstdc++ more appropriate location.
6 years, 2 months ago (2014-10-17 06:48:43 UTC) #3
Junichi Uekawa
On 2014/10/17 06:48:43, yanagisawa wrote: > As we talked offline, I have moved the installing ...
6 years, 2 months ago (2014-10-17 07:29:10 UTC) #4
Junichi Uekawa
https://codereview.chromium.org/647193004/diff/20001/build/install-chroot.sh File build/install-chroot.sh (right): https://codereview.chromium.org/647193004/diff/20001/build/install-chroot.sh#newcode662 build/install-chroot.sh:662: lib64expat1 lib64ncurses5 ${readlinepkg} lib64z1 libstdc++6:amd64 a bit worrysome that ...
6 years, 2 months ago (2014-10-17 07:29:18 UTC) #5
Yoshisato Yanagisawa
https://codereview.chromium.org/647193004/diff/20001/build/install-chroot.sh File build/install-chroot.sh (right): https://codereview.chromium.org/647193004/diff/20001/build/install-chroot.sh#newcode662 build/install-chroot.sh:662: lib64expat1 lib64ncurses5 ${readlinepkg} lib64z1 libstdc++6:amd64 On 2014/10/17 07:29:18, Junichi ...
6 years, 2 months ago (2014-10-17 07:40:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647193004/40001
6 years, 2 months ago (2014-10-17 08:23:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-17 08:45:58 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 08:47:30 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc73b4aa729c20d70540a5fe1411b2100a488450
Cr-Commit-Position: refs/heads/master@{#300080}

Powered by Google App Engine
This is Rietveld 408576698