tools/telemetry/telemetry/core/backends/browser_backend.py - Issue 647193002: Adding App, AndroidApp, AppBackend, AndroidAppBackend, PossibleApp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/browser_backend.py

Issue 647193002: Adding App, AndroidApp, AppBackend, AndroidAppBackend, PossibleApp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/app_backend.py ('k') | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/browser_backend.py b/tools/telemetry/telemetry/core/backends/browser_backend.py

index 283827b41bf8e1fb2698aac41241f7f01f2d18e1..dd3c9ee424d3265dc319b018dd07832ea6a5f79d 100644

--- a/tools/telemetry/telemetry/core/backends/browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/browser_backend.py

@@ -7,6 +7,7 @@ import os

from telemetry import decorators

from telemetry.core import platform

from telemetry.core import web_contents

+from telemetry.core.backends import app_backend

from telemetry.core.forwarders import do_nothing_forwarder

@@ -14,11 +15,12 @@ class ExtensionsNotSupportedException(Exception):

pass

-class BrowserBackend(object):

+class BrowserBackend(app_backend.AppBackend):

"""A base class for browser backends."""

def __init__(self, supports_extensions, browser_options, tab_list_backend):

assert browser_options.browser_type

+ super(BrowserBackend, self).__init__()

self.browser_type = browser_options.browser_type

self._supports_extensions = supports_extensions

self.browser_options = browser_options