Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 647163002: Adds dependency on //ui/chromeos/strings if chromeos (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds dependency on //ui/chromeos/strings if chromeos BUG=None R=nkostylev@chromium.org TEST=None Committed: https://crrev.com/77c14032e10595527563475e25b43fe9e01c201d Cr-Commit-Position: refs/heads/master@{#299322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M components/user_manager/BUILD.gn View 2 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
6 years, 2 months ago (2014-10-10 20:27:58 UTC) #1
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-13 08:44:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647163002/1
6 years, 2 months ago (2014-10-13 18:03:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 18:24:55 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 18:25:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77c14032e10595527563475e25b43fe9e01c201d
Cr-Commit-Position: refs/heads/master@{#299322}

Powered by Google App Engine
This is Rietveld 408576698