Issue 64713002: Move KillRing to platform/

Issue 64713002: Move KillRing to platform/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews, groby+blinkspell_chromium.org, darin (slow to review)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move KillRing to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161660

Patch Set 2 : move special cases from core.gyp #

Total comments: 2

Patch Set 3 : nits #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -196 lines)			Patch
M	Source/core/core.gyp	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/core.gypi	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/editing/Editor.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/EditorCommand.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/platform/KillRing.h	View		1 chunk	+0 lines, -45 lines	0 comments	Download
D	Source/core/platform/KillRingNone.cpp	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	Source/core/platform/mac/KillRingMac.mm	View		1 chunk	+0 lines, -83 lines	0 comments	Download
A +	Source/platform/KillRing.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	Source/platform/KillRingNone.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/blink_platform.gyp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
A +	Source/platform/mac/KillRingMac.mm	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

I think there are some special cases for this file in core.gyp that we need ...

7 years, 1 month ago (2013-11-07 18:30:17 UTC) #2

pilgrim_google

On 2013/11/07 18:30:17, abarth wrote: > I think there are some special cases for this ...

7 years, 1 month ago (2013-11-07 23:25:21 UTC) #3

abarth-chromium

lgtm https://codereview.chromium.org/64713002/diff/60001/Source/platform/blink_platform.gyp File Source/platform/blink_platform.gyp (right): https://codereview.chromium.org/64713002/diff/60001/Source/platform/blink_platform.gyp#newcode114 Source/platform/blink_platform.gyp:114: ['include', 'mac/KillRingMac\\.mm$'], I don't think this line is ...

7 years, 1 month ago (2013-11-07 23:31:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/64713002/190001

7 years, 1 month ago (2013-11-08 22:45:32 UTC) #5

Message was sent while issue was closed.

Change committed as 161660

Expand Messages | Collapse Messages