components/autofill/core/browser/personal_data_manager.cc - Issue 647123002: Adding instrumentation to locate the source of jankiness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 647123002: Adding instrumentation to locate the source of jankiness. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autocomplete_history_manager.cc ('k') | components/search_engines/template_url_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/personal_data_manager.cc

diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc

index dd5baecd6b0ae209de2b5ef6dd44e767fa83e463..6434dec2d7e6929e6edec875373f239c14ef5bfe 100644

--- a/components/autofill/core/browser/personal_data_manager.cc

+++ b/components/autofill/core/browser/personal_data_manager.cc

@@ -12,6 +12,7 @@

#include "base/logging.h"

#include "base/memory/ref_counted.h"

#include "base/prefs/pref_service.h"

+#include "base/profiler/scoped_profile.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

@@ -188,6 +189,11 @@ PersonalDataManager::~PersonalDataManager() {

void PersonalDataManager::OnWebDataServiceRequestDone(

WebDataServiceBase::Handle h,

const WDTypedResult* result) {

+ // TODO(vadimt): Remove ScopedProfile below once crbug.com/422460 is fixed.

+ tracked_objects::ScopedProfile tracking_profile(

+ FROM_HERE_WITH_EXPLICIT_FUNCTION(

+ "422460 PersonalDataManager::OnWebDataServiceRequestDone"));

DCHECK(pending_profiles_query_ || pending_creditcards_query_);

if (!result) {