Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 647103003: Make telemetry_unittests.py work on Windows (Closed)

Created:
6 years, 2 months ago by Paweł Hajdan Jr.
Modified:
6 years, 2 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/scripts/telemetry_unittests.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bartfab (slow)
lgtm
6 years, 2 months ago (2014-10-22 13:22:19 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f9f4000b3b94e82f7cf22277c649618f0bb97b66 Cr-Commit-Position: refs/heads/master@{#300676}
6 years, 2 months ago (2014-10-22 13:25:14 UTC) #3
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as f9f4000b3b94e82f7cf22277c649618f0bb97b66.
6 years, 2 months ago (2014-10-22 13:25:50 UTC) #4
jam
6 years, 2 months ago (2014-10-22 16:23:24 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/671933002/ by jam@chromium.org.

The reason for reverting is: windows trybots broken

please be around after landing changes and verify that bots are working.

Powered by Google App Engine
This is Rietveld 408576698