Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 647103002: Remove valgrind suppressions for WebContentsVideoCaptureDeviceTest (Closed)

Created:
6 years, 2 months ago by mark a. foltz
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, miu
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove suppressions as tests now pass. TESTED=Build valgrind on Linux/Mac, tests pass 100/100 times. BUG=159234, 227278, 222532 Committed: https://crrev.com/ff7e802c8548647f8fa6c4f4d7848f3b2b5baac2 Cr-Commit-Position: refs/heads/master@{#299194}

Patch Set 1 #

Patch Set 2 : Remove additional suppression #

Patch Set 3 : Resuppress WCVCDT.BadFramesGoodFrames in Mac valgrind #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/content_unittests.gtest_mac.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mark a. foltz
6 years, 2 months ago (2014-10-10 20:34:34 UTC) #2
Lei Zhang
lgtm, hope they work on the real bots too.
6 years, 2 months ago (2014-10-10 20:52:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647103002/30001
6 years, 2 months ago (2014-10-10 21:02:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:30001)
6 years, 2 months ago (2014-10-10 21:47:20 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ff7e802c8548647f8fa6c4f4d7848f3b2b5baac2 Cr-Commit-Position: refs/heads/master@{#299194}
6 years, 2 months ago (2014-10-10 21:48:18 UTC) #7
miu
6 years, 2 months ago (2014-10-11 01:58:18 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698