Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 647093002: Re-enable ensemble tests on Windows Release builds. (Closed)

Created:
6 years, 2 months ago by Will Harris
Modified:
6 years, 2 months ago
Reviewers:
dgarrett
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable ensemble tests on Windows Release builds. This is only taking a long time on Debug, because of the additional iterator validators running on all the stl objects being used. BUG=101614 Committed: https://crrev.com/6e7226194f0c3390dd07829098f9da132bca03c5 Cr-Commit-Position: refs/heads/master@{#299437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M courgette/ensemble_unittest.cc View 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Will Harris
Evidence for this change: Running in Debug, VersioningTest.All takes 3345ms: [42/45] VersioningTest.All (3345 ms) Running ...
6 years, 2 months ago (2014-10-10 18:57:29 UTC) #2
Will Harris
results from the bots confirm that I think this should be okay: win_chromium_rel speeds: [39/48] ...
6 years, 2 months ago (2014-10-10 19:49:55 UTC) #3
dgarrett
LGTM
6 years, 2 months ago (2014-10-14 01:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647093002/1
6 years, 2 months ago (2014-10-14 02:06:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/67282) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/57351) mac_gpu_triggered_tests ...
6 years, 2 months ago (2014-10-14 02:09:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647093002/1
6 years, 2 months ago (2014-10-14 06:11:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 06:12:15 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 06:17:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e7226194f0c3390dd07829098f9da132bca03c5
Cr-Commit-Position: refs/heads/master@{#299437}

Powered by Google App Engine
This is Rietveld 408576698