Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 647083003: Reinstall the hotword shared module on a lanuage change. (Closed)

Created:
6 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
6 years, 2 months ago
Reviewers:
rpetterson, benwells
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rlp+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reinstall the hotword shared module on a lanuage change. BUG=397019 Committed: https://crrev.com/fb484ab82ec0f2f1741c055885b3700955649c0a Cr-Commit-Position: refs/heads/master@{#300429}

Patch Set 1 #

Patch Set 2 : Modify test. #

Patch Set 3 : Test update. #

Total comments: 2

Patch Set 4 : Split common extension condition into function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -34 lines) Patch
M chrome/browser/extensions/extension_service_test_base.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/search/hotword_service.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 2 3 6 chunks +19 lines, -17 lines 0 comments Download
M chrome/browser/search/hotword_service_unittest.cc View 1 2 3 16 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Anand Mistry (off Chromium)
benwells@chromium.org: Please review changes in rlp@chromium.org: Please review changes in
6 years, 2 months ago (2014-10-20 04:04:14 UTC) #2
rpetterson
On 2014/10/20 04:04:14, Anand Mistry wrote: > mailto:benwells@chromium.org: Please review changes in > > mailto:rlp@chromium.org: ...
6 years, 2 months ago (2014-10-20 06:31:12 UTC) #3
rpetterson
https://codereview.chromium.org/647083003/diff/50001/chrome/browser/search/hotword_service.cc File chrome/browser/search/hotword_service.cc (right): https://codereview.chromium.org/647083003/diff/50001/chrome/browser/search/hotword_service.cc#newcode284 chrome/browser/search/hotword_service.cc:284: extension_id = extension_misc::kHotwordExtensionId; You're repeating this code a lot ...
6 years, 2 months ago (2014-10-20 06:31:21 UTC) #4
Anand Mistry (off Chromium)
https://codereview.chromium.org/647083003/diff/50001/chrome/browser/search/hotword_service.cc File chrome/browser/search/hotword_service.cc (right): https://codereview.chromium.org/647083003/diff/50001/chrome/browser/search/hotword_service.cc#newcode284 chrome/browser/search/hotword_service.cc:284: extension_id = extension_misc::kHotwordExtensionId; On 2014/10/20 06:31:21, rpetterson wrote: > ...
6 years, 2 months ago (2014-10-20 10:04:49 UTC) #5
rpetterson
lgtm
6 years, 2 months ago (2014-10-20 18:25:52 UTC) #6
benwells
c/b/e lgtm
6 years, 2 months ago (2014-10-21 04:45:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647083003/70001
6 years, 2 months ago (2014-10-21 05:58:25 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:70001)
6 years, 2 months ago (2014-10-21 06:29:20 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 06:30:22 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fb484ab82ec0f2f1741c055885b3700955649c0a
Cr-Commit-Position: refs/heads/master@{#300429}

Powered by Google App Engine
This is Rietveld 408576698