Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 647053003: Include remoting-webapp v2 in build target chromoting_integration_tests_run. (Closed)

Created:
6 years, 2 months ago by anandc
Modified:
6 years, 2 months ago
Reviewers:
weitao, Lei Lei
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add remoting_webapp_v2 as a dependency to chromoting_integration_tests_run. BUG= Committed: https://crrev.com/292ae659c9790a5045ac830ec9f9888847fc9f8b Cr-Commit-Position: refs/heads/master@{#299796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/chromoting/integration_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
anandc
Hi Lei, PTAL. Thanks.
6 years, 2 months ago (2014-10-10 21:21:47 UTC) #2
Lei Lei
Please include this cl into issue 657433002 to create a complete cl.
6 years, 2 months ago (2014-10-14 02:02:34 UTC) #3
anandc
On 2014/10/14 02:02:34, Lei Lei wrote: > Please include this cl into issue 657433002 to ...
6 years, 2 months ago (2014-10-14 16:25:30 UTC) #4
Lei Lei
lgtm
6 years, 2 months ago (2014-10-15 01:57:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647053003/1
6 years, 2 months ago (2014-10-15 18:52:08 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-15 18:52:11 UTC) #9
anandc
Weitao, could you please take a look? Thanks.
6 years, 2 months ago (2014-10-15 20:46:15 UTC) #11
weitao
On 2014/10/15 20:46:15, anandc wrote: > Weitao, could you please take a look? Thanks. LGTM
6 years, 2 months ago (2014-10-15 23:18:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647053003/1
6 years, 2 months ago (2014-10-15 23:22:27 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 00:37:59 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:38:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/292ae659c9790a5045ac830ec9f9888847fc9f8b
Cr-Commit-Position: refs/heads/master@{#299796}

Powered by Google App Engine
This is Rietveld 408576698