Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 647053002: Make remote CoreAnimation GPU-switching aware (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make remote CoreAnimation GPU-switching aware Send the CGL renderer ID for the context being used by the CAOpenGLLayer. Tested with WebGL apps, gfxCardStatus switching. BUG=312462 Committed: https://crrev.com/0707401c21b531d870f924c715949a2aca53394f Cr-Commit-Position: refs/heads/master@{#299204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M content/common/gpu/image_transport_surface_calayer_mac.mm View 2 chunks +10 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.mm View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
ccameron
(okay, this is the right codereview ...) When using IOSurfaces, I found that I needed ...
6 years, 2 months ago (2014-10-10 18:34:00 UTC) #2
jbauman
lgtm
6 years, 2 months ago (2014-10-10 21:24:47 UTC) #4
ccameron
thanks!
6 years, 2 months ago (2014-10-10 21:25:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647053002/1
6 years, 2 months ago (2014-10-10 21:25:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/67349) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/57431) mac_gpu_triggered_tests ...
6 years, 2 months ago (2014-10-10 21:41:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647053002/1
6 years, 2 months ago (2014-10-10 21:48:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 22:34:32 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0707401c21b531d870f924c715949a2aca53394f Cr-Commit-Position: refs/heads/master@{#299204}
6 years, 2 months ago (2014-10-10 22:35:08 UTC) #13
Ken Russell (switch to Gerrit)
6 years, 2 months ago (2014-10-10 23:09:38 UTC) #14
Message was sent while issue was closed.
LGTM if this has been tested. I recall there were rendering issues on some
dual-GPU machines the first time we attempted to forcibly set the CGL renderer
ID.

Powered by Google App Engine
This is Rietveld 408576698