Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issue 647043007: Add OWNERS for chrome/android/java/res directory. (Closed)

Created:
6 years, 2 months ago by newt (away)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, aurimas (slooooooooow), Yusuf, gone
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add OWNERS for chrome/android/java/res directory. Changes to these files are always UI-related and should be reviewed by someone familiar with Chrome Android UI. Committed: https://crrev.com/98babcf3410e52f785c8ee210de395accaba7894 Cr-Commit-Position: refs/heads/master@{#300990}

Patch Set 1 #

Patch Set 2 : make aapt ignore OWNERS files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M build/android/gyp/package_resources.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/gyp/process_resources.py View 1 3 chunks +5 lines, -2 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/android/java/res/OWNERS View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
newt (away)
dpranke: is this OWNERS file valid? I'm trying to specify OWNERS for the "res" directory, ...
6 years, 2 months ago (2014-10-23 19:03:58 UTC) #2
Dirk Pranke
On 2014/10/23 19:03:58, newt wrote: > dpranke: is this OWNERS file valid? I'm trying to ...
6 years, 2 months ago (2014-10-23 19:33:49 UTC) #3
newt (away)
On 2014/10/23 19:33:49, Dirk Pranke wrote: > On 2014/10/23 19:03:58, newt wrote: > > dpranke: ...
6 years, 2 months ago (2014-10-23 20:18:45 UTC) #4
Dirk Pranke
On 2014/10/23 20:18:45, newt wrote: > On 2014/10/23 19:33:49, Dirk Pranke wrote: > > On ...
6 years, 2 months ago (2014-10-23 20:24:04 UTC) #5
newt (away)
cjhopman: build/android/gyp tedchoc/dtrainor: chrome/android/java/res/OWNERS
6 years, 2 months ago (2014-10-23 21:57:36 UTC) #7
David Trainor- moved to gerrit
lgtm
6 years, 2 months ago (2014-10-23 22:05:22 UTC) #8
Ted C
lgtm
6 years, 2 months ago (2014-10-23 22:06:06 UTC) #9
cjhopman
lgtm
6 years, 2 months ago (2014-10-23 22:07:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647043007/20001
6 years, 2 months ago (2014-10-23 22:27:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 23:52:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 23:52:51 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:53:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98babcf3410e52f785c8ee210de395accaba7894
Cr-Commit-Position: refs/heads/master@{#300990}

Powered by Google App Engine
This is Rietveld 408576698