Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 647043005: Revert of Revert of Support GLSL es 3.00 (Closed)

Created:
6 years, 2 months ago by rmistry
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Revert of Support GLSL es 3.00 (patchset #1 id:1 of https://codereview.chromium.org/661603009/) Reason for revert: DEPS roll still failing: https://codereview.chromium.org/661993002/ Reverting the revert. Original issue's description: > Revert of Support GLSL es 3.00 (patchset #5 id:80001 of https://codereview.chromium.org/659443007/) > > Reason for revert: > Trying to fix DEPS roll failure: > https://codereview.chromium.org/660113002/ > > Link to failing builds: > http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29578 > http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29354 > > Original issue's description: > > Support GLSL es 3.00 > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/62372bcc6abe3537dac98dd9b9172cf3b85afa2b > > TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/79b2b1fb12202d22411b607a095cb26c6e4fe8b7 TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/63a9f842a12c8ce265ca7a8c43117e2e7129ac83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 3 chunks +21 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmistry
Created Revert of Revert of Support GLSL es 3.00
6 years, 2 months ago (2014-10-17 13:06:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647043005/1
6 years, 2 months ago (2014-10-17 13:07:00 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 13:07:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 63a9f842a12c8ce265ca7a8c43117e2e7129ac83

Powered by Google App Engine
This is Rietveld 408576698