Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 647043004: WizardScreen is merged to BaseScreen. (Closed)

Created:
6 years, 2 months ago by ygorshenin1
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

WizardScreen is merged to BaseScreen. BUG=405876 TEST=existing unit_tests and browser_tests Committed: https://crrev.com/15c0c0fe08941e41ae56a564d8a1b3954f708a1e Cr-Commit-Position: refs/heads/master@{#300099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -184 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screen_manager.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.h View 4 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/base_screen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/controller_pairing_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/eula_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/hid_detection_screen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/host_pairing_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_enable_screen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/mock_screen_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/screen_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/terms_of_service_screen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/login/screens/wizard_screen.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/chromeos/login/screens/wizard_screen.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ygorshenin1
6 years, 2 months ago (2014-10-17 12:47:35 UTC) #2
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-17 13:18:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647043004/1
6 years, 2 months ago (2014-10-17 13:19:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 14:01:48 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 14:02:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/15c0c0fe08941e41ae56a564d8a1b3954f708a1e
Cr-Commit-Position: refs/heads/master@{#300099}

Powered by Google App Engine
This is Rietveld 408576698