Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 647043003: Switch to 2013 now that it's what's on the bots (Closed)

Created:
6 years, 2 months ago by scottmg
Modified:
6 years, 1 month ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Switch to 2013 now that it's what's on the bots Chromium only supports 2013 now, and the bots no longer have older versions. Support for other versions still maintained, just not on buildbot. R=sbaig1@bloomberg.net Committed: https://code.google.com/p/gyp/source/detail?r=1996

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : disable non-working msvs tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M buildbot/buildbot_run.py View 1 1 chunk +3 lines, -4 lines 0 comments Download
M test/rules-rebuild/gyptest-default.py View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M test/win/gyptest-link-enable-winrt.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/win/gyptest-macro-targetfilename.py View 1 2 1 chunk +16 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
scottmg
(No idea if this will work, see if the try runs are ok) I think ...
6 years, 2 months ago (2014-10-10 22:32:06 UTC) #1
Shezan Baig (Bloomberg)
On 2014/10/10 22:32:06, scottmg wrote: > (No idea if this will work, see if the ...
6 years, 2 months ago (2014-10-10 22:34:58 UTC) #2
Shezan Baig (Bloomberg)
LGTM I have to head out -- I'll update my CL later from home. Thanks!
6 years, 2 months ago (2014-10-10 22:35:48 UTC) #3
scottmg
Apparently we lost VS2010.
6 years, 2 months ago (2014-10-10 23:12:20 UTC) #4
scottmg
On 2014/10/10 23:12:20, scottmg wrote: > Apparently we lost VS2010. And 2013 fails some tests. ...
6 years, 2 months ago (2014-10-11 00:32:55 UTC) #5
scottmg
We apparently can't put old VSs on these bots, so I'm going to land this ...
6 years, 1 month ago (2014-10-30 21:14:10 UTC) #7
scottmg
6 years, 1 month ago (2014-10-30 21:14:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:200001) manually as 1996 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698