src/ports/SkImageDecoder_empty.cpp - Issue 647023006: Qualify the return value of SkImageDecoder::decode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkImageDecoder_empty.cpp

Issue 647023006: Qualify the return value of SkImageDecoder::decode (Closed) Base URL: https://skia.googlesource.com/skia.git/+/master

Patch Set: fix a sample Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkImageDecoder_empty.cpp

diff --git a/src/ports/SkImageDecoder_empty.cpp b/src/ports/SkImageDecoder_empty.cpp

index 7824732bb9320a9303010c545590ab7e1672e3f4..722b7d45f8be6949d0751b3e82dcdf1a6d6821b6 100644

--- a/src/ports/SkImageDecoder_empty.cpp

+++ b/src/ports/SkImageDecoder_empty.cpp

@@ -32,8 +32,8 @@ bool SkImageDecoder::DecodeFile(const char[], SkBitmap*, SkColorType, Mode, Form

return false;

}

-bool SkImageDecoder::decode(SkStream*, SkBitmap*, SkColorType, Mode) {

- return false;

+SkImageDecoder::Result SkImageDecoder::decode(SkStream*, SkBitmap*, SkColorType, Mode) {

+ return kFailure;

}

bool SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*, SkColorType, Mode, Format*) {

« no previous file with comments | « src/ports/SkImageDecoder_WIC.cpp ('k') | tests/ImageDecodingTest.cpp » ('j') | no next file with comments »